[FFmpeg-devel] [PATCH] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

Michael Niedermayer michael at niedermayer.cc
Wed Jun 21 04:44:55 EEST 2017

On Mon, Jun 19, 2017 at 10:34:34PM +0200, Daniel Kucera wrote:
> transfer_func variable passed to retry_transfer_wrapper are
> h->prot->url_read and h->prot->url_write functions. These need
> to return EOF or other error properly. In case of returning >= 0,
>  url_read/url_write is retried until error is returned.
> requires patch: libavformat/cache: don't treat 0 as EOF
> Signed-off-by: Daniel Kucera <daniel.kucera at gmail.com>
> ---
>  libavformat/avio.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Question from last review, still applies:

(Does this patch requires changes in protocols ? )
If so did you (or someone else) review all protocols to identify which
need to be updated ?

also it seems to infinite loop with the concat protocol
./ffmpeg -i concat:matrixbench_mpeg2.mpg|matrixbench_mpeg2.mpg file.avi

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170621/4ec69c38/attachment.sig>

More information about the ffmpeg-devel mailing list