[FFmpeg-devel] [PATCH V5 1/4] lavc/golomb: add value range comment for set_ue_golomb().

[Michael Niedermayer]

On Wed, Jun 14, 2017 at 11:00:50AM +0800, Jun Zhao wrote:
> V5: Split the patch.
> V4: Fix rang check error in assert base on Mark's review
> V3: Clean the code logic base on Michael's review.
> V2: Add set_ue_golomb_long() to support 32bits UE golomb and update the unit test.

>  golomb.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 4272a9227cf925217ba1b3349e3209421bea198b  0001-lavc-golomb-add-value-range-comment-for-set_ue_golom.patch
> From 4600950115a215d64cf049233195cfd035ac11cb Mon Sep 17 00:00:00 2001
> From: Jun Zhao <jun.zhao at intel.com>
> Date: Wed, 14 Jun 2017 10:08:58 +0800
> Subject: [PATCH V5 1/4] lavc/golomb: add value range comment for
>  set_ue_golomb().
> 
> set_ue_golomb just support 2^16 - 2 at most, becase this function call
> put_bits, and put_bits just support write up to 31 bits, when write 32
> bit in put_bits, it's will overwrite the bit buffer, and the default
> assert level is 0, the av_assert2(n <= 31 && value < (1U << n)) in
> put_bits can not be trigger runtime.
> 
> Signed-off-by: Jun Zhao <jun.zhao at intel.com>
> ---
>  libavcodec/golomb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170623/0f3acedc/attachment.sig>