[FFmpeg-devel] [PATCH v2] lavu: add ff_pthread_setname() and use it in various places

Moritz Barsnick barsnick at gmx.net
Sat Jun 24 19:03:45 EEST 2017


On Fri, Jun 23, 2017 at 21:00:03 +0100, Rostislav Pehlivanov wrote:
> +#if HAVE_PTHREAD_SETNAME_NP && defined(__linux__)
> +#include <sys/prctl.h>
> +#endif

You're not using pthread_getname_np() on Linux, so perhaps you should
be checking for prctl() instead? And since pthread_getname_np()
apparently isn't available before glibc-2.12, while prctl() with
PR_SET_NAME certainly is (it's kernel, not glibc, right?), you're
restricting yourself a bit.

Moritz


More information about the ffmpeg-devel mailing list