[FFmpeg-devel] [PATCH v11] - Added Turing codec interface for ffmpeg
nfxjfg at googlemail.com
Thu Jun 29 23:44:05 EEST 2017
On Thu, 29 Jun 2017 21:26:47 +0100
Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 6/29/2017 9:09 PM, wm4 wrote:
> > On Thu, 29 Jun 2017 20:45:10 +0100
> > Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> >> Keep in mind that C99 bool and C++
> >> bool are not compatible.
> > (Actually they are.)
> Source? Because, from e.g. glibc:
> /* Supporting <stdbool.h> in C++ is a GCC extension. */
> And AFAICT, there is *nothing* that guarantees C99's _Bool matches
> C++'s bool in size or alignment. It's compiler and ABI dependent
> and just happens to work with GCC/G++, no?
I meant that both "bool" types are meant to be ABI compatible. (And it
holds up even on Windows with MSVC vs. GCC.)
But yeah, this would at least require including the correct header for
whatever language is used, and C would be forced to at least C99.
(FFmpeg uses C99 though.)
Anyway, getting offtopic. A build failure seems a bit like a deal
breaker, and maybe the strcpy should be killed.
More information about the ffmpeg-devel