[FFmpeg-devel] [PATCH]lavf/matroska: Support codec id V_FFV1 for FFV1.

James Almer jamrial at gmail.com
Thu Mar 2 01:26:25 EET 2017

On 3/1/2017 7:18 PM, Carl Eugen Hoyos wrote:
> 2017-03-01 17:56 GMT+01:00 James Almer <jamrial at gmail.com>:
>> On 2/28/2017 4:45 PM, Carl Eugen Hoyos wrote:
>>> Hi!
>>> Attached patch fixes ticket #6206 here.
>>> Please comment, Carl Eugen
>> This doesn't consider the CodecPrivate contents for FFV1 v3
>> and above. It's only valid for v1 and v2.
> Is this comment meant for the muxer or the demuxer part?
> How can I reproduce the issue you see?
> For me, everything works as specified for default strictness.

Ah, i see there's generic code to read and write CodecPrivate elements
to and from raw extradata for native codecids where no special handling
is required.

In any case, the spec says

"For FFV1 versions 2 or less, Private Data SHOULD NOT be written."

The ffv1 encoder creates extradata for v2 and newer, so the muxer
should have a custom case for ffv1 in order to detect v2 streams and
avoid writing said extradata.

> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

More information about the ffmpeg-devel mailing list