[FFmpeg-devel] fate: Do not report side data size
michael at niedermayer.cc
Wed Mar 8 13:51:06 EET 2017
On Wed, Mar 08, 2017 at 12:28:17PM +0100, Hendrik Leppkes wrote:
> On Wed, Mar 8, 2017 at 1:17 AM, Vittorio Giovara
> <vittorio.giovara at gmail.com> wrote:
> > This should address the mismatch between different archs
iam not in favor of this solution
> Removing the side_data_size from output should be fine, as its a
> implementation detail and as seen here can even vary between
> architecture or possibly even compiler.
> Maybe someone that uses that ffprobe output more often can comment?
I use all kinds of stuff
if something is removed from ffprobes output it wont be tested anymore.
We should test more not less.
> An alternative for fixing fate would be to use fixed size fields in
> the new sidedata, although the possibility of it breaking similarly
> again in the future then remains.
I strongly prefer fixed size to be used in side data over platform
dependant fields. Not only does size become testable but theres also
a platform specific difference less in the interface which should
help bug reproducability between platforms
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel