[FFmpeg-devel] fate: Do not report side data size
michael at niedermayer.cc
Thu Mar 9 02:45:29 EET 2017
On Wed, Mar 08, 2017 at 11:54:59PM +0100, Hendrik Leppkes wrote:
> On Wed, Mar 8, 2017 at 3:42 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > Hi,
> > On Wed, Mar 8, 2017 at 9:31 AM, wm4 <nfxjfg at googlemail.com> wrote:
> >> On Wed, 8 Mar 2017 14:09:53 +0100
> >> Michael Niedermayer <michael at niedermayer.cc> wrote:
> >> If the size printing is removed then other code should be added
> >> > to test for the size to match the correct value
> >> Then it would be more reasonable to make av_packet_add_side_data()
> >> check whether the size is correct for the given side data type.
> > I think you're both right here, this is a pretty good idea (for fixed-size
> > side-data types).
> So how do we fix fate now? Change the datatypes to uint32_t, remove
> the size print out?
why is the data type size_t and not uint32_t int64_t or unsigned int ?
independant of the fate issue i mean, size_t seems a strange choice
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel