[FFmpeg-devel] [PATCH 1/3] aacdec: do not mutate input packet metadata
nfxjfg at googlemail.com
Thu Mar 9 11:21:54 EET 2017
On Wed, 8 Mar 2017 14:28:33 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Wed, Mar 08, 2017 at 01:40:10PM +0100, wm4 wrote:
> > Apparently the demuxer outputs the wrong padding for HE-AAC (based on
> > the raw sample rate, or so). aacdec contains a hack to adjust the muxer
> > padding accordingly before it's used to trim the decoder output. This
> > modified the packet side data, which in combination with the old
> > decoding API would change the packet the user passed to the decoder.
> > This is clearly not allowed, and it breaks running some gapless fate
> > tests with "-fflags +keepside" applied (without keepside, the packet
> > metadata is typically newly allocated, essentially making a copy and not
> > modifying the user's input packet).
> > This should probably be fixed in the demuxer (and consequently also the
> > muxer), but for now only fix the immediate problem.
> > Regression since 946ed78f5f8 (2012).
> > ---
> > libavcodec/aacdec_template.c | 8 ++------
> > libavcodec/internal.h | 2 ++
> > libavcodec/utils.c | 4 +++-
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> this patch LGTM
More information about the ffmpeg-devel