[FFmpeg-devel] [PATCH] Added AVX2 implementation for VP8 decoder (ff_pred16x16_tm_vp8_8_avx2)

Michael Niedermayer michael at niedermayer.cc
Sun Mar 12 05:13:24 EET 2017


On Sun, Mar 12, 2017 at 12:35:01AM +0530, Mirage Abeysekara wrote:
> ---
>  libavcodec/x86/h264_intrapred.asm    | 35 +++++++++++++++++++++++++++++++++++
>  libavcodec/x86/h264_intrapred_init.c |  7 +++++++
>  2 files changed, 42 insertions(+)
> 

breaks build with nasm

src/libavcodec/x86/h264_intrapred.asm:275: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:281: error: symbol `vpbroadcastb' redefined
src/libavcodec/x86/h264_intrapred.asm:281: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:282: error: symbol `vpbroadcastb' redefined
src/libavcodec/x86/h264_intrapred.asm:282: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:283: error: symbol `vpbroadcastb' redefined
src/libavcodec/x86/h264_intrapred.asm:283: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:284: error: symbol `vpbroadcastb' redefined
src/libavcodec/x86/h264_intrapred.asm:284: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:295: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:296: error: symbol `vpermq' redefined
src/libavcodec/x86/h264_intrapred.asm:296: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:298: error: parser: instruction expected
src/libavcodec/x86/h264_intrapred.asm:300: error: symbol `vextracti128' redefined
src/libavcodec/x86/h264_intrapred.asm:300: error: parser: instruction expected


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170312/96551d96/attachment.sig>


More information about the ffmpeg-devel mailing list