[FFmpeg-devel] [PATCH 5/6] h264: don't sync pic_id between threads.

Ronald S. Bultje rsbultje at gmail.com
Wed Mar 29 17:12:23 EEST 2017

This is how the ref list manager links bitstream IDs to H264Picture/Ref
objects, and is local to the producer thread. There is no need for the
consumer thread to know the bitstream IDs of its references in their
respective producer threads.

In practice, this fixes the last tsan warnigns when running fate-h264.
 libavcodec/h264_picture.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c
index db96737..2dbe5ee 100644
--- a/libavcodec/h264_picture.c
+++ b/libavcodec/h264_picture.c
@@ -109,7 +109,6 @@ int ff_h264_ref_picture(H264Context *h, H264Picture *dst, H264Picture *src)
     dst->poc           = src->poc;
     dst->frame_num     = src->frame_num;
     dst->mmco_reset    = src->mmco_reset;
-    dst->pic_id        = src->pic_id;
     dst->long_ref      = src->long_ref;
     dst->mbaff         = src->mbaff;
     dst->field_picture = src->field_picture;

More information about the ffmpeg-devel mailing list