[FFmpeg-devel] [PATCH 1/6] h264: don't write to source picture object in ff_h264_ref_picture().

[Michael Niedermayer]

On Wed, Mar 29, 2017 at 10:12:19AM -0400, Ronald S. Bultje wrote:
> Doing so is analogous to writing to source data in memcpy(), and causes
> (harmless) tsan warnings in fate-h264.
> ---
>  libavcodec/h264_picture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c
> index f634d2a..db96737 100644
> --- a/libavcodec/h264_picture.c
> +++ b/libavcodec/h264_picture.c
> @@ -70,8 +70,8 @@ int ff_h264_ref_picture(H264Context *h, H264Picture *dst, H264Picture *src)
>  
>      av_assert0(!dst->f->buf[0]);
>      av_assert0(src->f->buf[0]);
> +    av_assert0(src->tf.f == src->f);
>  
> -    src->tf.f = src->f;

should be ok

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170330/59c1a335/attachment.sig>