[FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

Ronald S. Bultje rsbultje at gmail.com
Mon May 1 19:45:46 EEST 2017


On Mon, May 1, 2017 at 12:44 PM, Ronald S. Bultje <rsbultje at gmail.com>

> Hi,
> On Sun, Apr 30, 2017 at 1:16 PM, wm4 <nfxjfg at googlemail.com> wrote:
>> I think it's probably ok to push your current patch, since the original
>> author of the patch who broke this probably won't fix it.
> I don't like the patch because it essentially duplicates the C
> implementation of the DSP function. If we do that here, are we going to do
> that everywhere? Will we get 2 DSP functions, aligned and unaligned? I
> foresee a mess.
> Michael already said that too, I believe.

Let me expand a little bit further:
- if we agree that the API does not require alignment, then we should fix
the DSP function (and others in other filters) to allow non-aligned or
differently-aligned input data.
- if not, then the data alignment should be fixed.


More information about the ffmpeg-devel mailing list