[FFmpeg-devel] [PATCH v9] - Added Turing codec interface for ffmpeg

Saverio Blasi Saverio.Blasi at bbc.co.uk
Wed May 3 12:29:14 EEST 2017


Dear Carl,

Thanks for your email.
Yes, I can confirm that the patch as it is generated with "git format-patch -1" passes the patcheck test without highlighting any trailing whitespaces.
I can see though that the email that gets sent with "git send" has some new lines which are not in the original patch. For instance:
+                             die "ERROR: libturing requires turing api
+version 2 or greater."; }

There is a new line between "api" and "version" which is not in the original patch file, which may lead to a trailing whitespace (after "api") in case the patch is generated copying and pasting the text from the email. I am not sure why these new lines are automatically generated and how to avoid that, would you be able to provide some help with this?

Thanks a lot for your help,
Saverio

p.s. I am afraid I cannot avoid the email footer, please ignore it.

________________________________________
From: ffmpeg-devel [ffmpeg-devel-bounces at ffmpeg.org] on behalf of Carl Eugen Hoyos [ceffmpeg at gmail.com]
Sent: 30 April 2017 12:21
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH v9] - Added Turing codec interface for       ffmpeg

2017-04-28 17:18 GMT+02:00 Saverio Blasi <Saverio.Blasi at bbc.co.uk>:

> The patch applies nicely to my local ffmpeg repository.

Please confirm that tools/patcheck does not report any issues
(trailing whitespace cannot be committed to our repository).

> This e-mail (and any attachments) is confidential

Please do not top-post here and please remove this
from your email footer, you cannot send a confidential
email to a public mailing list.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


-----------------------------
http://www.bbc.co.uk
This e-mail (and any attachments) is confidential and
may contain personal views which are not the views of the BBC unless specifically stated.
If you have received it in
error, please delete it from your system.
Do not use, copy or disclose the
information in any way nor act in reliance on it and notify the sender
immediately.
Please note that the BBC monitors e-mails
sent or received.
Further communication will signify your consent to
this.
-----------------------------


More information about the ffmpeg-devel mailing list