[FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (dashj.js, shaka, VLC, etc.)

Aaron Levinson alevinsn at aracnet.com
Fri May 5 08:50:23 EEST 2017


On 5/2/2017 2:29 PM, wm4 wrote:
> On Tue, 2 May 2017 14:17:33 -0700
> Aaron Levinson <alevinsn at aracnet.com> wrote:
>
>> On 5/1/2017 11:06 PM, MFojtak wrote:
>>> Currently this muxer does not work at all. I don't know if 000Z would make
>>> it compatible with more player as I don't know any. However, adding Z makes
>>> it compatible with most popular ones like dash.js and shaka. Having this
>>> muxer working properly would bring more attention to it and maybe in the
>>> future somebody tests it with more players. But for now I suggest to roll
>>> out the change and "unblock" this muxer for some real wold use. Also, it
>>> would be great to make this muxer codec and container agnostic as it works
>>> with h264 and mp4 only. But again, nobody would bother if the muxer doesn't
>>> work at all with browsers.
>>
>> I think your original patch is fine, and I only offered the possibility
>> that adding ".000Z" might be even better than just "Z".  I don't have
>> push privileges, so I can't commit your patch, but hopefully someone
>> else will do so.
>
> Before someone pushes it, please fix the commit message.

MFojtak:  you can make it more likely that this patch will be pushed 
sooner by altering the commit message (shortening it--plenty of examples 
on the e-mail list) and then putting any additional information later. 
Something like:

"
avformat/dashenc:  Adjusts ISO date formatting for improved 
compatibility with most players

Adjusts ISO date formatting....
"

Aaron Levinson


More information about the ffmpeg-devel mailing list