[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Nicolas George george at nsup.org
Fri May 5 13:00:02 EEST 2017


Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit :
> This should fix Ticket6349.
> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may
> generate unaligned frame data.
> 
> Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
> ---
>  libavfilter/avfilter.c | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)

Sorry, but no.

According to the C standard and FFmpeg's developer documentation, the
current output of libavfilter is correctly aligned, and libmp3lame is
misbehaving.

Therefore, you have only two options :

- fix libmp3lame ;

- change the documentation to shift the burden elsewhere.

Note that changing libavfilter is not an option. If you change the
documentation tu put the burden on libavfilter, then this patch can go
in, but the documentation change must come first.

Note that I will argue for a good documentation change, not something
rushed and inconvenient.

Regards,

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list