[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Muhammad Faiz mfcc64 at gmail.com
Sat May 6 18:49:59 EEST 2017

On Sat, May 6, 2017 at 9:36 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi Muhammad,
> On Sat, May 6, 2017 at 10:13 AM, Muhammad Faiz <mfcc64 at gmail.com> wrote:
>> On Fri, May 5, 2017 at 11:22 PM, Nicolas George <george at nsup.org> wrote:
>> > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit :
>> >>                                                   But if documentation
>> >> says that data should be aligned to 4-bytes but I align it to
>> >> 32-bytes, then there are no violations at all. So what's wrong with
>> >> this patch?
>> >
>> > Useless code performing wasteful operations in speed-critical sections.
>> This is not speed-critical section.
> Not in this case, no. But I believe we have multiple issues in this area
> and some of the affected areas _are_ speed-critical.

I guess, those speed-critical areas are video frames. Because the data
is larger.

> Plus, we like speed even if it's pointless. There's no problem with that.

But it should not generate crash.


More information about the ffmpeg-devel mailing list