[FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_check_align().

Ronald S. Bultje rsbultje at gmail.com
Sun May 14 16:10:15 EEST 2017


On Sun, May 14, 2017 at 6:07 AM, Nicolas George <george at nsup.org> wrote:

> Le duodi 22 floréal, an CCXXV, Michael Niedermayer a écrit :
> > The direct value like 32 feels more natural to me too, but iam fine
> > with either.
> >
> > The avoidance of log() might also favor the other in some cases btw
> > consider you have a 32 and need to call a fuction that needs a log2(32)
> So, shall I push?

No, Mohammad's point that you don't check linesize is not answered. Whether
or not the doxy says that it shall or shall not be bla bla doesn't really
matter, we're introducing API here so the user doesn't have to worry about
it, so we should possibly relax those constraints in the API and
check/reallocate here also.

With the current code or without the 1<<?

In log2 units (so 4, 5 instead of 16, 32) is fine.

More information about the ffmpeg-devel mailing list