[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

[Muhammad Faiz]

On Wed, May 17, 2017 at 3:20 PM, Nicolas George <george at nsup.org> wrote:
> L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit :
>> Of course, pushing the partial fix won't conflict with the complete
>> fix.
>
> Of course it will, it touches the same area of code.

No, your code doesn't check the alignment at take_samples.

>
>> Ha ha ha. Of course, that's why I prefer the partial fix. Because it
>> is simple.
>
> It is simple because it is incomplete.

But it is enough to fix ticket 6349.

>
>>               We assume that at first data and linesize are always
>> aligned, so we only need to check data[0] alignment.
>
> Untrue. You only need to check data[0] because you only want to fix a
> tiny case of the more general bug.

With the assumption that ff_framequeue_skip_samples is the only source
of unaligned audio data and the framework doesn't mix between
ff_inlink_consume_frame and ff_inlink_consume_samples, this partial
fix is enough to fix ticket 6349.

Thank's.