[FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

[Muhammad Faiz]

On Thu, May 18, 2017 at 10:37 PM, Nicolas George <george at nsup.org> wrote:
> Le nonidi 29 floréal, an CCXXV, Muhammad Faiz a écrit :
>> >> Should fix Ticket6349.
>
> Forgot: please remove that, it is not true. The bug in this ticket is in
> libavcodec, it cannot be fixed by a change in libavfilter.

In my opinion, it can. The bigger problem about alignment should be
separated from this ticket e.g opening new ticket that gives failed
alignment test case.

>
>> IMHO, the solution is to document it properly to not mix
>> ff_inlink_consume_samples with ff_inlink_consume_frame, similar to
>> av_buffersink_get_frame vs av_buffersink_get_samples.
>
> Maybe. I am not sure I like this solution, but it should be technically
> acceptable, unlike no change at all. I would like better something that
> gives the performance boost you observe without limiting the
> expressiveness of the API, but I do not know if it is possible.

A patch documenting it has been posted.

Thank's.