[FFmpeg-devel] [PATCH 1/3] libavfilter/scale2ref: Add constants for the non-ref input

Kevin Mark kmark937 at gmail.com
Sun May 28 17:36:22 EEST 2017

On Sat, May 27, 2017 at 8:29 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> main_*
> and
> ref_*
> are maybe prefixes that would work without conflicting with the
> existing ones

I'm partial to main_* since when I think of ref_* that makes me think
of the input being used "as basis" (in the words of the documentation)
or reference. Any thoughts on creating shorthand variables? I don't
see a particular need for them but it would put these new variables in
line with the others. mw for main_w, mh for main_h. Potentially ma for
main_a. I don't have a strong feeling on it one way or another.

This is my first patch set to FFmpeg (huzzah!) so I have a few quick
questions before continuing. What is the preferred way to revise a
patch? From my understanding git send-email is only useful for the
initial patch. Unless revised patches should be new threads? Or should
I just reply to this thread with attachments from git format-patch?
Although now that I'm looking at it, git send-email has an
--in-reply-to option that could potentially do the trick of submitting
the revised patch. This mailing list patch submission workflow is new
to me so I appreciate any guidance.


More information about the ffmpeg-devel mailing list