[FFmpeg-devel] Support for h264/SVC over RTP and SVC base layer decoding in h264

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Nov 1 17:57:21 EET 2017

2017-11-01 16:18 GMT+01:00 Breeden, Joshua <JBREED05 at harris.com>:
>> Your patches contain a lot of trailing whitespace (afaict...)
>> that cannot be committed to our repository, please remove it.
> Thanks for pointing this out. I've attached new patches to fix this problem.

> patcheck complains about my non-doxy comments, and about possible
> unused variables. Variables are definitely being used.

The tool is not perfect.

> Is the etiquette to remove all comments?

No but I wonder if the variables "y" and "t" can have more useful names
(that may or may not make the comment unneeded),

> Also, I added a Changelog entry for the RTP depacketization of SVC as
> patcheck suggested.

Please do not remove the empty line.

Carl Eugen

More information about the ffmpeg-devel mailing list