[FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

Timo Rothenpieler timo at rothenpieler.org
Mon Nov 6 14:19:18 EET 2017


Am 05.11.2017 um 14:35 schrieb James Almer:
> On 11/5/2017 9:34 AM, Michael Niedermayer wrote:
>> This gives libavcodec a field that it can freely and safely use.
>> Avoiding the need of wraping of a users opaque_ref field and its issues.
> 
> Could this perhaps be in an opaque internal struct instead, much like
> AVCodecInternal and whatnot? As wm4 said in the relevant discussion,
> this approach is nonoptimal and *will* snowball into a mess of fields if
> other libav* libraries start requiring their own buffers in a frame.
> An internal field of an opaque struct being in a public header is much
> cleaner and easier to maintain than adding such specific fields that may
> at some point in the future need to be removed.

The problem here is that avcodec, due to nested decoders and the like, 
might potentially wrap this field multiple times internally, so it 
basically has to be something avcodec specific.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3994 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171106/418f1510/attachment.bin>


More information about the ffmpeg-devel mailing list