[FFmpeg-devel] [PATCH] avfilter:vf_libvmaf: fix errors while running with psnr=1 and improve docs

Ronald S. Bultje rsbultje at gmail.com
Mon Nov 6 22:27:47 EET 2017


On Mon, Nov 6, 2017 at 1:58 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> It is one thing to know that within FFmpeg, we do not modify
> a pointer target and therefore decide to cast, but isn't it
> another (bad) thing to assume this for an external library?

I'm guessing that what you mean is "libvmaf may not touch it right now, but
the API doesn't guarantee that such an implementation detail doesn't change
in the future", right?

Yes, you're right. Potential solutions are to make libvmaf const-correct or
to strdup in our implementation. I'm fine with both, although I'd prefer if
we didn't strdup every frame, i.e. move it to some global init/uninit


More information about the ffmpeg-devel mailing list