[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

Michael Niedermayer michael at niedermayer.cc
Sun Nov 12 18:08:46 EET 2017

On Sat, Nov 11, 2017 at 08:36:32AM +0000, Thomas Köppe wrote:
> Variables used in inline assembly need to be marked with attribute((used)).
> Static constants already were, via the define of DECLARE_ASM_CONST.
> But DECLARE_ALIGNED does not add this attribute, and some of the variables
> defined with it are const only used in inline assembly, and therefore
> appeared dead. This change adds a macro DECLARE_ASM_ALIGNED that marks
> variables as used.
> This change makes FFMPEG work with Clang's ThinLTO.
> ---
>  libavcodec/cabac.c         |  2 +-
>  libavcodec/x86/constants.c | 20 ++++++++++----------
>  libavutil/mem.h            | 20 ++++++++++++++++++++
>  libswscale/x86/swscale.c   | 12 ++++++------
>  4 files changed, 37 insertions(+), 17 deletions(-)

doesnt apply cleanly anymore

Applying: Fix missing used attribute for inline assembly variables
Using index info to reconstruct a base tree...
M       libavutil/mem.h
Falling back to patching base and 3-way merge...
Auto-merging libavutil/mem.h
CONFLICT (content): Merge conflict in libavutil/mem.h
error: Failed to merge in the changes.
Patch failed at 0001 Fix missing used attribute for inline assembly variables
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171112/62eee94d/attachment.sig>

More information about the ffmpeg-devel mailing list