[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

Michael Niedermayer michael at niedermayer.cc
Mon Nov 13 04:46:36 EET 2017


On Sun, Nov 12, 2017 at 04:24:37PM +0000, Thomas Köppe wrote:
> Variables used in inline assembly need to be marked with attribute((used)).
> Static constants already were, via the define of DECLARE_ASM_CONST.
> But DECLARE_ALIGNED does not add this attribute, and some of the variables
> defined with it are const only used in inline assembly, and therefore
> appeared dead. This change adds a macro DECLARE_ASM_ALIGNED that marks
> variables as used.
> 
> This change makes FFMPEG work with Clang's ThinLTO.
> ---
>  libavcodec/cabac.c         |  2 +-
>  libavcodec/x86/constants.c | 20 ++++++++++----------
>  libavutil/mem.h            | 17 +++++++++++++++++
>  libswscale/x86/swscale.c   | 12 ++++++------
>  4 files changed, 34 insertions(+), 17 deletions(-)

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171113/1b4268f4/attachment.sig>


More information about the ffmpeg-devel mailing list