[FFmpeg-devel] Avoid corrupting diagnostic state with _Pragma changes.

Michael Niedermayer michael at niedermayer.cc
Tue Nov 14 21:59:01 EET 2017


On Fri, Nov 03, 2017 at 05:13:58PM -0700, Dale Curtis wrote:
> The macros for ICC and MSVC correctly push and pop the diagnostic
> state of the compiler when disabling deprecation warnings. The
> ones for clang/gcc should do the same. Without this, if a blanket
> deprecation warning is applied to the code base it'll be flipped
> back on incorrectly with FF_ENABLE_DEPRECATION_WARNINGS.
> 
> Signed-off-by: Dale Curtis <dalecurtis at chromium.org>

>  internal.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ecc5e46d6354c52e1a6df9813d446e5f58a93321  fix_pragma.patch
> From 73a488e07a328d05aa2b507a551b0c1e4b8a81c8 Mon Sep 17 00:00:00 2001
> From: Dale Curtis <dalecurtis at chromium.org>
> Date: Fri, 3 Nov 2017 17:10:55 -0700
> Subject: [PATCH] Avoid corrupting diagnostic state with _Pragma changes.
> 
> The macros for ICC and MSVC correctly push and pop the diagnostic
> state of the compiler when disabling deprecation warnings. The
> ones for clang/gcc should do the same. Without this, if a blanket
> deprecation warning is applied to the code base it'll be flipped
> back on incorrectly with FF_ENABLE_DEPRECATION_WARNINGS.
> 
> Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
> ---
>  libavutil/internal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

will apply

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171114/ca096711/attachment.sig>


More information about the ffmpeg-devel mailing list