[FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

[Thilo Borgmann]

Am 14.11.17 um 08:23 schrieb Umair Khan:
> Hi,
> 
> On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2017-11-13 6:41 GMT+01:00 Umair Khan <omerjerk at gmail.com>:
>>> Hi,
>>>
>>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>> 2017-11-12 20:30 GMT+01:00 Umair Khan <omerjerk at gmail.com>:
>>>>> Hi,
>>>>>
>>>>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>>> 2017-11-12 20:05 GMT+01:00 Umair Khan <omerjerk at gmail.com>:
>>>>>>
>>>>>>> The attached patch fixes the address sanitizer issue.
>>>>>>
>>>>>> Breaks compilation here, how did you test?
>>>>>>
>>>>>> libavcodec/alsdec.c: In function ‘decode_var_block_data’:
>>>>>> libavcodec/alsdec.c:938:7: error: expected ‘}’ before ‘else’
>>>>>
>>>>> Sorry for the faulty patch. Here is the fixed one.
>>>>
>>>> The commit message of your patch is:
>>>> libavcodec/als: fix address sanitization error in decoder
>>>>
>>>> Is there an error in current FFmpeg git head that asan
>>>> shows? If not, the commit message makes no sense.
>>>>
>>>> I believe you should send two patches that are meant
>>>> to be committed together, one of them fixing ticket #6297.
>>>
>>> This is the complete patchset.
>>
>> Bonus points for mentioning the ticket number in the
>> commit message (can be done by the committer).
>>
>> Thank you for looking into this!
> 
> I have attached the complete patch. Ticket link is mentioned in the
> commit description.

Thanks, will have a look at it asap!

-Thilo