[FFmpeg-devel] [PATCH 2/3] avfilter/vf_cropdetect: don't ignore frames, export crop parameters

Nicolas George george at nsup.org
Sun Nov 19 18:29:00 EET 2017

Le septidi 27 brumaire, an CCXXVI, Aman Gupta a écrit :
> From: Aman Gupta <aman at tmm1.net>
> ---
>  libavfilter/vf_cropdetect.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

I think the changes belong in different commits, since they both change
the behaviour of the filter in different ways.

I cannot comment on the frame_nb change.

Regarding the frame crop change, I am quite doubtful: filters currently
do not handle these fields at all, yet they are copied automatically in
many cases. I am rather against adding an isolated change like that,
unless there is a clear and obvious use case.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171119/70df9b36/attachment.sig>

More information about the ffmpeg-devel mailing list