[FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

Dale Curtis dalecurtis at chromium.org
Mon Nov 20 22:01:11 EET 2017


Derp, that's the wrong comment for this; I meant that for another thread.
Returning an error for optional user data seems a bit harsh, but if that's
what you want, I'm happy to change it. Please let me know if this is the
route you want to take.

- dale

On Mon, Nov 20, 2017 at 11:55 AM, Dale Curtis <dalecurtis at chromium.org>
wrote:

> On Fri, Nov 17, 2017 at 6:22 PM, Michael Niedermayer <
> michael at niedermayer.cc> wrote:
>>
>> Not sure what is best but
>> throwing part of the version silently away is not correct
>> most likely erroring out and asking for a sample video to be uploaded
>> would make sense if such a file is encountered
>
>
> I'm using the same workaround used throughout the rest of the file; so
> please clarify if you want me to change this. Happy to change to an error
> w/ patches_welcome if you prefer.
>
> - dale
>


More information about the ffmpeg-devel mailing list