[FFmpeg-devel] [PATCH] avfilter: add lv2 wrapper filter

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Nov 24 19:24:51 EET 2017


On 11/23/2017 9:16 PM, Paul B Mahol wrote:

> +typedef struct LV2Context {
> +    const AVClass *class;
> +    char *plugin_uri;
> +    char *options;
> +
> +    unsigned long nb_inputs;
> +    unsigned long nb_inputcontrols;
> +    unsigned long nb_outputs;

Why are you using longs instead of stdint?

> +    table->uris = av_realloc(table->uris, ++table->n_uris * sizeof(char*));
> +    table->uris[table->n_uris - 1] = av_malloc(len + 1);

Every single allocation in this whole file is completely unchecked. That's not OK.

- Derek


More information about the ffmpeg-devel mailing list