[FFmpeg-devel] [PATCH] tests/checkasm/float_dsp: Increase allowed difference for float_dsp.vector_dmul

James Almer jamrial at gmail.com
Mon Nov 27 01:13:51 EET 2017


On 11/26/2017 8:09 PM, Michael Niedermayer wrote:
> On Sun, Nov 26, 2017 at 12:47:22AM +0100, Michael Niedermayer wrote:
>> On Sun, Nov 26, 2017 at 12:10:38AM +0100, Michael Niedermayer wrote:
>>> On Fri, Nov 24, 2017 at 11:37:36PM -0300, James Almer wrote:
>>>> On 10/29/2017 11:57 AM, Michael Niedermayer wrote:
>>>>> The choosen value is the lowest power of 2 that allows 1000 iterations of fate-checkasm-float_dsp
>>>>> to pass on x86-32
>>>>
>>>> Ticket #6848 reports this value is still not enough. Maybe something
>>>> like 1.0e-12 or 1.0e-13 instead?
>>>
>>> ok, ill push it with 1e-12
>>
>> Or do people prefer this: (this should be more correct)
>>
>> commit 67ba87a320faba623c0b35a0692adb916860ac40 (HEAD -> master)
>> Author: Michael Niedermayer <michael at niedermayer.cc>
>> Date:   Sun Oct 29 15:26:50 2017 +0100
>>
>>     tests/checkasm/float_dsp: Increase allowed difference for float_dsp.vector_dmul
>>
>>     Tested for 10000 iterations on x86-32
>>
>>     Fixes: Ticket6848
>>
>>     Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> 
> ill push a variant of this so that gets fixed. We can change it
> later if people prefer somthing else
> leaving it open is bad ...

Any solution is fine with me. Thanks for fixing it.


More information about the ffmpeg-devel mailing list