[FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

Neil Birkbeck neil.birkbeck at gmail.com
Wed Nov 29 04:14:49 EET 2017

On Tue, Nov 28, 2017 at 5:14 PM, Neil Birkbeck <neil.birkbeck at gmail.com>

> -    //The srcBpc check is possibly wrong but we seem to lack a definitive
> reference to test this
> -    //and what we have in ticket 2939 looks better with this check
> -    if (need_reinit && (c->srcBpc == 8 || !isYUV(c->srcFormat)))
> +    if (need_reinit)
>          ff_sws_init_range_convert(c);

Wanted to check and see if someone more familiar with this condition can
comment as to whether some parts of it may still be necessary.

Also, this may also need to be coupled with a change to vf_scale.
E.g., at the moment, I think scaling >10bit YUV without explicit _range
settings may not change color range of the data (but it may assign
incorrect color_range flag to the frame).

More information about the ffmpeg-devel mailing list