[FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

[Rostislav Pehlivanov]

On 2 October 2017 at 18:43, pkv.stream <pkv.stream at gmail.com> wrote:

> Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit :
>
>> On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote:
>>
>>> Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit :
>>>
>>>> 2017-10-02 0:40 GMT+02:00 pkv.stream <pkv.stream at gmail.com>:
>>>>
>>>>> Hi atomnuker,
>>>>>
>>>>> got your PCE working;
>>>>>
>>>> the patch you attached contains tabs, they cannot be committed
>>>> to the FFmpeg repository, please remove them.
>>>> (Or one tab.)
>>>>
>>> thanks for pointing out.
>>> Removed the offending tab.
>>>
>>> Thank you, Carl Eugen
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel at ffmpeg.org
>>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>
>>>
>>>   aacenc.h |  239 ++++++++++++++++++++++++++++++
>>> +++++++++++++++++++++++++++++++--
>>>   1 file changed, 233 insertions(+), 6 deletions(-)
>>> 929275fe34af4d0048bac2be928957288cb75ddd  0001-avcodec-aacenc-PCE-for-al
>>> l-ffmpeg-usual-layouts.patch
>>>  From 647fb61708bc1279f9dc17c679052a778dce5fbb Mon Sep 17 00:00:00 2001
>>> From: pkviet <pkv.stream at gmail.com>
>>> Date: Sun, 24 Sep 2017 16:11:17 +0200
>>> Subject: [PATCH] avcodec/aacenc: PCE for all ffmpeg usual layouts
>>>
>> this seems not to apply cleanly here, did i miss something ?
>>
>
> Hi Michael
> this needs to be applied after the initial patch by atomnuker which he did
> not apply since this required work.
> What i submitted was not aimed at being pushed since there is probably
> still work to do.
> Depending on what he wants to do with his patch, I'll resubmit a working
> patch later, properly rebased.
> Sorry about the mess.
> regards
>
>
>> Applying: avcodec/aacenc: PCE for all ffmpeg usual layouts
>> error: sha1 information is lacking or useless (libavcodec/aacenc.h).
>> error: could not build fake ancestor
>> Patch failed at 0001 avcodec/aacenc: PCE for all ffmpeg usual layouts
>> The copy of the patch that failed is found in: .git/rebase-apply/patch
>>
>>
>> [...]
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


Give me a few hours and I'll test it and submit a v2 of my patch with your
improvements.