[FFmpeg-devel] [PATCH] avformat/mp3dec: Fix definition of MIDDLE_BITS

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Oct 4 00:14:14 EEST 2017


2017-10-03 15:50 GMT+02:00 Ingo Br├╝ckl <ib at wupperonline.de>:
> The number of bits from bit #m to #n is n - m plus 1.

> -#define MIDDLE_BITS(k, m, n) LAST_BITS((k) >> (m), ((n) - (m)))
> +#define MIDDLE_BITS(k, m, n) LAST_BITS((k) >> (m), ((n) - (m) + 1))

I cannot comment on this patch but if this fixes a sample
of yours, please add a fate test.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list