[FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Moritz Barsnick barsnick at gmx.net
Thu Oct 5 00:18:40 EEST 2017


On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote:
>      if (!ost->stream_copy) {
> -        char *sample_fmt = NULL;
> +
> +		char *sample_fmt = NULL;
>  

This is very obviously a patch which will not be accepted.


> -        MATCH_PER_STREAM_OPT(sample_fmts, str, sample_fmt, oc, st);
> +		AVDictionaryEntry *output_layout = av_dict_get(o->g->codec_opts, "channel_layout",NULL, AV_DICT_MATCH_CASE);
> +        if (output_layout)
> +            ost->enc_ctx->channel_layout = strtoull(output_layout->value, NULL, 10);
> +
> +		MATCH_PER_STREAM_OPT(sample_fmts, str, sample_fmt, oc, st);

Your indentation is totally wrong, and makes use of tabs. Please follow
the ffmpeg style.

Moritz


More information about the ffmpeg-devel mailing list