[FFmpeg-devel] [PATCH] Fix visual glitch with XvMC, caused by wrong idct permutation.

Ronald S. Bultje rsbultje at gmail.com
Mon Oct 9 16:02:38 EEST 2017


Hi,

On Mon, Oct 9, 2017 at 6:46 AM, Ivan Kalvachev <ikalvachev at gmail.com> wrote:

> On 10/9/17, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Sun, Oct 8, 2017 at 6:52 PM, Ivan Kalvachev <ikalvachev at gmail.com>
> wrote:
> > [..]
> >
> > Indentation is off in the second hunk, can you fix that?
>
> You want it 4 spaces to the right
>

Yes, please.

BTW, I think it would be better to use "127" number.
>

I don't really mind either way. The number 128 suggests it may have been
intended as a bitmask. Michael is probably better positioned to comment on
this.

Ronald


More information about the ffmpeg-devel mailing list