[FFmpeg-devel] [PATCH v2] Fix visual glitch with XvMC, caused by wrong idct permutation.
ikalvachev at gmail.com
Tue Oct 10 02:53:43 EEST 2017
On 10/9/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Mon, Oct 09, 2017 at 09:02:38AM -0400, Ronald S. Bultje wrote:
>> On Mon, Oct 9, 2017 at 6:46 AM, Ivan Kalvachev <ikalvachev at gmail.com>
>> > On 10/9/17, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> > > On Sun, Oct 8, 2017 at 6:52 PM, Ivan Kalvachev <ikalvachev at gmail.com>
>> > wrote:
>> > > [..]
>> > >
>> > > Indentation is off in the second hunk, can you fix that?
>> > You want it 4 spaces to the right
>> Yes, please.
>> BTW, I think it would be better to use "127" number.
>> I don't really mind either way. The number 128 suggests it may have been
>> intended as a bitmask. Michael is probably better positioned to comment
> I don't really remember but i think 128 was chosen for ABI
> compatibility with additions to it from libav. So it should no longer
> matter what values are used on additions
Then I'm using the next free number "24".
Please, commit when you think it is appropriate.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2355 bytes
Desc: not available
More information about the ffmpeg-devel