[FFmpeg-devel] [PATCH] avformat/srt: add Haivision Open SRT protocol

nablet developer sdk at nablet.com
Wed Oct 11 06:57:03 EEST 2017


> Has this patch been run under valgrind, on Windows, and with stuff like ASAN, etc.?
> Some stuff here would even trigger compiler warnings normally.
compiled on Windows, but didn't run under valgrind or ASAN yet.
> Also, how much of this stuff is duplicated from the udp.c and pals?
>
you're absolutely right - this patch is based on udp.c (actually I 
initially copied udp.c and replaced bsd sockets to corresponding SRT 
calls, with some additional modifications).

thanks for the review, I am going to correct all errors, as well as run 
recommended tools.


More information about the ffmpeg-devel mailing list