[FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

[Bjorn Roche]

On Tue, Oct 10, 2017 at 5:56 PM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 10/10/2017 10:41 PM, Bjorn Roche wrote:
> > Partial fix for https://trac.ffmpeg.org/ticket/4443
> > (Animated GIFs are incorrectly optimized, so they still won’t be output
> > correctly).
> > ---
> >  libavfilter/vf_paletteuse.c | 210 ++++++++++++++++++++++++++++--
> --------------
> >  1 file changed, 132 insertions(+), 78 deletions(-)
>
> Commit message should contain info on what changed and why, not just a bug
> URL.
>
> - Derek


>From my Git, the commit message is:

Fix for paletteuse to support transparency

and the body is

Partial fix for https://trac.ffmpeg.org/ticket/4443

(Animated GIFs are incorrectly optimized, so they still won’t be output

correctly).

I then used git format-patch followed by git send-email. Now the commit
message is the subject of the email and the body of the commit is in the
body of the email.

Can you explain where I went wrong? Is "Fix for paletteuse to support
transparency" incorrect or not sufficient? Do you require that I repeat the
message in the body as well? Or perhaps I invoked my git commands
incorrectly?

Thanks,

bjorn