[FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

Marton Balint cus at passwd.hu
Wed Oct 18 22:29:14 EEST 2017


On Wed, 18 Oct 2017, Michael Niedermayer wrote:

> On Wed, Oct 18, 2017 at 09:48:16AM -0400, Compn wrote:
> [...]
>
>> a third party might be able to settle the stalemate.
>
> i strongly support this. And it was in part why i suggested to take
> this to the vote comittee. Most people from the vote committee are
> uninvolved in this
>
> This should be carefully looked at by people with cool heads and
> decided.

I tried to follow the discussion but I still don't get why adding a 
new "priv_ref" field to AVFrame for lavc internal use is frowned upon. 
It seems like the easiest solution to relax the concerns and a small 
price to pay to put this story behind us.

Unfortunately I don't know much about hwaccel, so I can't judge the 
whole patch series, but for me it is not evident that post-processing 
belongs to the decoder interface, if everybody agrees that it does, then 
OK.

I also find storing an AVBufferRef in an AVBufferRef a bit confusing, 
because sooner or later we won't know if we have to do a deep ref on 
referencing an avframe, or not, so I'd try to avoid that in general.

Regards,
Marton


More information about the ffmpeg-devel mailing list