[FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

[Michael Niedermayer]

On Wed, Oct 18, 2017 at 12:46:13PM -0700, Michael Bradshaw wrote:
> Thanks for the review!
> 
> On Wed, Oct 18, 2017 at 12:26 PM, James Almer <jamrial at gmail.com> wrote:
> >
> > Add a line to Changelog about dropping support for OpenJPEG <= 2.0.
> >
> 
> Done.
> 
> > +enabled libopenjpeg       && require_pkg_config libopenjpeg libopenjp2
> > openjpeg.h opj_version
> >
> > OpenJPEG 2.0.1 ships a pkg-config file, so change the second argument to
> > "libopenjp2 >= 2.1.0".
> >
> 
> Thanks for catching that; I didn't realize 2.0.1 included pkg-config
> support. Fixed.
> 
> Aside from that LGTM. It's nice to see all the bloat gone and every
> > future 2.x version being supported without further changes from now on.
> 
> 
> Yeah, I look forward to the decreased maintenance costs!
> 
> Attached is an updated patch with the requested changes to configure and
> Changelog. I plan on pushing this in a few hours (unless, of course, there
> are additional critiques).

>  Changelog                   |    2 
>  configure                   |   16 ----
>  libavcodec/libopenjpegdec.c |  103 +----------------------------
>  libavcodec/libopenjpegenc.c |  156 +++++++-------------------------------------
>  4 files changed, 34 insertions(+), 243 deletions(-)
> e3a7a5c8ebe0d5c0b0eb92c0e61871ab5e9e285e  0001-lavc-drop-support-for-OpenJPEG-1.3-2.0.patch
> From fb8334d0cecc889ebce3af968c56a3afbd2f6047 Mon Sep 17 00:00:00 2001
> From: Michael Bradshaw <mjbshaw at google.com>
> Date: Wed, 18 Oct 2017 11:34:06 -0700
> Subject: [PATCH] lavc: drop support for OpenJPEG 1.3-2.0
> 
> We now require 2.1+ with pkg-config.

This drops support for all ubuntu versions, there seems to be no
openjpeg above 1.5 in there

https://packages.ubuntu.com/search?keywords=openjpeg&searchon=names&suite=all&section=all
from Package openjpeg-tools, the others are spread over multiple package names
    trusty (14.04LTS) (graphics): command-line tools using the JPEG 2000 library [universe]
    1.3+dfsg-4.7ubuntu1: amd64 arm64 armhf i386 powerpc ppc64el
    xenial (16.04LTS) (graphics): command-line tools using the JPEG 2000 library [universe]
    1:1.5.2-3.1: amd64 arm64 armhf i386 powerpc ppc64el s390x
    zesty (graphics): command-line tools using the JPEG 2000 library [universe]
    1:1.5.2-3.1 [ports]: powerpc

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171018/22b3ebc9/attachment.sig>