[FFmpeg-devel] [PATCH]lavc/hevcdec: Silence warnings when decoding DolbyVision

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Oct 25 01:04:56 EEST 2017


2017-10-23 14:40 GMT+02:00 James Almer <jamrial at gmail.com>:
> On 10/23/2017 5:09 AM, Carl Eugen Hoyos wrote:
>> 2017-10-23 5:22 GMT+02:00 James Almer <jamrial at gmail.com>:
>>> On 10/21/2017 9:31 PM, Carl Eugen Hoyos wrote:
>>>> Hi!
>>>>
>>>> Attached patch silences the many warnings shown when decoding streams
>>>> with DolbyVision content.
>>>>
>>>> Please comment, Carl Eugen
>>>>
>>>>
>>>> 0001-lavc-hevcdec-Silence-warnings-when-decoding-DolbyVis.patch
>>>>
>>>>
>>>> From d917eb3470b957fe17d8b708957567fdfa9dbdaa Mon Sep 17 00:00:00 2001
>>>> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
>>>> Date: Sun, 22 Oct 2017 02:17:27 +0200
>>>> Subject: [PATCH] lavc/hevcdec: Silence warnings when decoding DolbyVision.
>>>>
>>>> ---
>>>>  libavcodec/hevcdec.c |    2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
>>>> index 2e4add2..d5ed9f5 100644
>>>> --- a/libavcodec/hevcdec.c
>>>> +++ b/libavcodec/hevcdec.c
>>>> @@ -2933,6 +2933,8 @@ static int decode_nal_unit(HEVCContext *s, const H2645NAL *nal)
>>>>          break;
>>>>      case HEVC_NAL_AUD:
>>>>      case HEVC_NAL_FD_NUT:
>>>> +    case 62: // unspecified, used by DolbyVision
>>>> +    case 63: // unspecified, used by DolbyVision
>>>
>>> No, the log message should be set to verbose level instead, like
>>> inff_hevc_decode_extradata(). It's something of little value for the
>>> info level and effectively just spams stderr when trying to decode files
>>> with unofficial or currently unsupported NAL units.
>>
>> Don't we want users to upload such samples?
>
> Nothing in the current log messages hints the user to provide
> us with samples.

Experience indicates that users provide us with samples
that spam stderr.

Carl Eugen


More information about the ffmpeg-devel mailing list