[FFmpeg-devel] [PATCH 3/3] lavf/aviobuf: return EINVAL when reading from a write-only context.

[Hendrik Leppkes]

On Wed, Oct 25, 2017 at 10:22 AM, Nicolas George <george at nsup.org> wrote:
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavformat/aviobuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Not related to the issue, but seems more correct.
>
>
> diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
> index bb5bcf7a14..dfe8437b18 100644
> --- a/libavformat/aviobuf.c
> +++ b/libavformat/aviobuf.c
> @@ -534,7 +534,7 @@ static int read_packet_wrapper(AVIOContext *s, uint8_t *buf, int size)
>  #if FF_API_OLD_AVIO_EOF_0
>      if (!ret && !s->max_packet_size) {
>          av_log(s, AV_LOG_WARNING, "Invalid return value 0 for stream protocol\n");
> -        ret = AVERROR_EOF;
> +        ret = AVERROR(EINVAL);
>      }
>  #else
>      av_assert2(ret || s->max_packet_size);
> --

I think you meant to change the other ret assignment?

- Hendrik