[FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

Carl Eugen Hoyos ceffmpeg at gmail.com
Sun Oct 29 16:06:40 EET 2017


2017-10-29 13:39 GMT+01:00 Michael Niedermayer <michael at niedermayer.cc>:
> On Sat, Oct 28, 2017 at 08:26:16PM +0200, Michael Niedermayer wrote:
>> On Thu, Oct 26, 2017 at 08:51:50PM -0700, Sasi Inguva wrote:

>> >  libavformat/mov.c                           |   21 +++++++++-
>> >  tests/fate/mov.mak                          |    4 +
>> >  tests/ref/fate/mov-invalid-elst-entry-count |   57 ++++++++++++++++++++++++++++
>> >  3 files changed, 81 insertions(+), 1 deletion(-)
>> > c553340f66797876d039f408f83574a40c54d17b  0001-lavf-mov.c-Fix-parsing-of-edit-list-atoms-with-inval.patch
>> > From 188602e662868a79c7f85e9193e9aedc9ba1a170 Mon Sep 17 00:00:00 2001
>> > From: Sasi Inguva <isasi at google.com>
>> > Date: Wed, 18 Oct 2017 20:11:16 -0700
>> > Subject: [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst
>> >  entry count.
>>
>> applied
>
> It seems this fails on ARM qemu

Fails differently here on ppc64be:

--- ./tests/ref/fate/mov-invalid-elst-entry-count       2017-10-28
22:32:57.766024470 +0000
+++ tests/data/fate/mov-invalid-elst-entry-count        2017-10-29
14:04:35.227325635 +0000
@@ -7,51 +7,51 @@
 #dimensions 0: 640x480
 #sar 0: 1/1
 #stream#, dts,        pts, duration,     size, hash
-0,          0,          0,        1,   460800, 549730883a0b56e6accaf021903daecf
-0,          1,          1,        1,   460800, 783389b4342d4be925fc5244791e760a
-0,          2,          2,        1,   460800, 8384af6426d94a2077930c93013e09ad
-0,          3,          3,        1,   460800, 9380a1d9ecacf5b3105383c1c8083188
-0,          4,          4,        1,   460800, eb28174acfceb868b9058757bed049c5
-0,          5,          5,        1,   460800, 9732bd4a58884dbf2be48d819433130f
-0,          6,          6,        1,   460800, 0c553fb530cf042eb84f5b13817a96a6
-0,          7,          7,        1,   460800, 621f02aded5e35fa1f373afd3ed283bd
-0,          8,          8,        1,   460800, c76167c6bda91f657708c88252ea315d
-0,          9,          9,        1,   460800, 872df2d8c522e2440ddd04bca7dce497
-0,         10,         10,        1,   460800, 6ee9154e48c5132ad4ba122b255bd2bb
-0,         11,         11,        1,   460800, 362e61629795702ebe9183ce3786d7f2
-0,         12,         12,        1,   460800, f3ec59e6fc4e3c2e75f42bef34ca73b5
-0,         13,         13,        1,   460800, 68d9caea8697736dd716cba43b614919
-0,         14,         14,        1,   460800, 4a4efb0201a64236db4330725758c139
-0,         15,         15,        1,   460800, f32f8997dcdd87ad910dea886a0de17d
-0,         16,         16,        1,   460800, 51a8549d7b4aaacaf6050bc07a82b440
-0,         17,         17,        1,   460800, 5145aa05bbb0c3faab40fc8fa233af1d
-0,         18,         18,        1,   460800, bbfcbe3c9600b2a0f413057d7959e9e7
-0,         19,         19,        1,   460800, 02cfd4a350fa274e12fce8352001bf21
-0,         20,         20,        1,   460800, 20dd372da9e656add433f31e3e9c1fb8
-0,         21,         21,        1,   460800, 3b885593f8b42676ce40c329a63f62bf
-0,         22,         22,        1,   460800, c38b453b56c3ea14f7d8691d83752486
-0,         23,         23,        1,   460800, 79643132988dabc9dc1ba3af0aeaebc5
-0,         24,         24,        1,   460800, 60a099be31244b2f69ca6107cdbd7e06
-0,         25,         25,        1,   460800, 1de6ff4e0aa81216e4b7b1c8e74fb143
-0,         26,         26,        1,   460800, 5223a81e6964c28cf42593f259397aa1
-0,         27,         27,        1,   460800, 2dfcf01c86aa712cd6f1c7656eeb17db
-0,         28,         28,        1,   460800, 8c86ee0f02fabccaed8d8fc8babd031e
-0,         29,         29,        1,   460800, b3ea1983f7efeec11306445d9ae5d477
-0,         30,         30,        1,   460800, 86a4cc9fa7db5ff5ca2be69ad191179f
-0,         31,         31,        1,   460800, 8194715afe23ae34a019797a53a6ee2c
-0,         32,         32,        1,   460800, 447a153f1c6bb703eff62edfd14e08e0
-0,         33,         33,        1,   460800, 092257082789b898dbb14d1f19e79347
-0,         34,         34,        1,   460800, d6320d204a119cfeef5645a4118bc600
-0,         35,         35,        1,   460800, 2ee710deae4bb0d156528797ad1c4981
-0,         36,         36,        1,   460800, 1256eac030985c04c4501ad5a72e9d66
-0,         37,         37,        1,   460800, f16ad8c1aa572be7666c7907ce4aebbc
-0,         38,         38,        1,   460800, 865088cbd47d0151b62a45d5426c8216
-0,         39,         39,        1,   460800, 26c78ca43d93c6da153f3dea5d945e0e
-0,         40,         40,        1,   460800, d775d6705c965401ccc143d5ae432938
-0,         41,         41,        1,   460800, f9837d514753c59e6776452d9043524f
-0,         42,         42,        1,   460800, 8463f5172914828abcc770f888bfd183
-0,         43,         43,        1,   460800, 3108557748cfb7965b33b16b35359de0
-0,         44,         44,        1,   460800, 477d596944e028dd72c207bb6e6b22de
-0,         45,         45,        1,   460800, 69e4ffbd600c8d8bc070d7d7324ee2b1
-0,         46,         46,        1,   460800, 2211c57bc9ec1788217002900f9102b1
-0,         47,         47,        1,   460800, bcfb5f0a7f88da3ec8c6b447ed4b67eb
+0,          0,          0,        1,   460800, 4a08c4fa53e02025ca698aba8cfe85df
+0,          1,          1,        1,   460800, 020e94a472e51a3cdeeee829aa52aaac
+0,          2,          2,        1,   460800, 5cab0035d7bc0c669fc220c213bca91a
+0,          3,          3,        1,   460800, 99f4da82dd19e91ebe41f6ae7cd55678
+0,          4,          4,        1,   460800, e67609abacb82cbe71661e309b94dfad
+0,          5,          5,        1,   460800, 2572c7691a795ffa6fc3739d975ab6ce
+0,          6,          6,        1,   460800, 74dcad292ea6e4fd997d35c0c89f32ba
+0,          7,          7,        1,   460800, 14b5f3ee154e6cf963e1d0238e39f935
+0,          8,          8,        1,   460800, 852e622431b2df7aee3a3b6be416fe11
+0,          9,          9,        1,   460800, 1c92d30597340196d85e48eb69ae3731
+0,         10,         10,        1,   460800, fed59cce13933cf3fc77e52d1cdbab3b
+0,         11,         11,        1,   460800, c7ff57fe043494bf589b7ed9af662093
+0,         12,         12,        1,   460800, 7ff9e3d4170b2bd53c7a82d704f61dfd
+0,         13,         13,        1,   460800, 70a48c539b07f41491191bd5bf3cb641
+0,         14,         14,        1,   460800, bf2c89c862cc255d2ce16776f6e18d48
+0,         15,         15,        1,   460800, 9410ee9a03a67bef668b2f95110fb21e
+0,         16,         16,        1,   460800, f8ea9b36f2f448c10d095b69d887eee7
+0,         17,         17,        1,   460800, 3959a273d8f1e830edd5fdb3bf02eafa
+0,         18,         18,        1,   460800, b4596024b3512be4f82492da22859be9
+0,         19,         19,        1,   460800, 555742238e273f7f2b81ae27bc3fc7dd
+0,         20,         20,        1,   460800, 0ddba2488002dc0d9fc4bcfe760c24ba
+0,         21,         21,        1,   460800, 3364bf8fc34508efd25e7b37516406fd
+0,         22,         22,        1,   460800, 3fb01bdeda657bb2673b70df7eb2c70d
+0,         23,         23,        1,   460800, bef8d3e2b722e79311bab50e38a48872
+0,         24,         24,        1,   460800, 8c072a41d1c0bd15e3dc69f2a826a08d
+0,         25,         25,        1,   460800, 26bd55391ff97f3b4e775d6327083420
+0,         26,         26,        1,   460800, 0a8a0f2f128d9698b12ac15d2487e4e9
+0,         27,         27,        1,   460800, 1477fd4e6452c1cf5a5e21868ae42086
+0,         28,         28,        1,   460800, 378641a8564e83164291d5754b1a0d17
+0,         29,         29,        1,   460800, 9b5ccf98982dc8b9f4297ac1f9d26a0b
+0,         30,         30,        1,   460800, 347e6ceb6792e374ed0c5f22b46ec29e
+0,         31,         31,        1,   460800, 707febefaec545d5c7587b9b8020c803
+0,         32,         32,        1,   460800, e3887ac397c73bf48f206009575b57c6
+0,         33,         33,        1,   460800, 327e0a9a1c7ead76b19f898cceb878d0
+0,         34,         34,        1,   460800, 44206e9bd73586377994c470fe7ba122
+0,         35,         35,        1,   460800, f81d054b8e0cc971c8691cdeed2ce08d
+0,         36,         36,        1,   460800, aa9d013200b8249d3be9af8b98fe723d
+0,         37,         37,        1,   460800, 063e387111509734e00fb60127e97eb1
+0,         38,         38,        1,   460800, 541a5efc9cb13bde0e0edccb7dceb2c7
+0,         39,         39,        1,   460800, 877ffed61eff3afd9377f7ae46d9c4f4
+0,         40,         40,        1,   460800, 8c755688e9784b67e37c2405fd46ead8
+0,         41,         41,        1,   460800, c151973719cf57337074efc1a1e6a04b
+0,         42,         42,        1,   460800, ebefe4c78f5dc0777c5b899acaea47ba
+0,         43,         43,        1,   460800, 9fbc39f4907064414d9cc6d585082100
+0,         44,         44,        1,   460800, 1f029a3c51f3a6293486763fe43c447c
+0,         45,         45,        1,   460800, bf92711a080b63264938f69775af9799
+0,         46,         46,        1,   460800, 34116e65a099e5eaf62e487331b5c700
+0,         47,         47,        1,   460800, 435e7e9ebc2c5773149da64a681e40bb
Test mov-invalid-elst-entry-count failed. Look at
tests/data/fate/mov-invalid-elst-entry-count.err for details.

Carl Eugen


More information about the ffmpeg-devel mailing list