[FFmpeg-devel] [PATCH 3/3] avcodec/scpr: optimize shift loop.

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat Sep 9 17:11:00 EEST 2017


On 9/8/2017 11:15 PM, James Almer wrote:
> It reads eight bytes at a time if the buffer is sufficiently aligned,
> then finishes reading the remaining bytes one at a time.
> If the buffer is unaligned, it reads everything one byte at a time like
> it used to.
> 
> See ff_h2645_extract_rbsp() and add_bytes_c() for another example of
> this optimization.

So put a comment, or at least put it in the commit message.

It isn't exactly straightforward; it's like reading Hex Rays output.

- Derek


More information about the ffmpeg-devel mailing list