[FFmpeg-devel] [PATCH] vp9: move VP9SharedContext back to the top of VP9Context

[Hendrik Leppkes]

On Tue, Sep 19, 2017 at 2:27 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Tue, Sep 19, 2017 at 4:51 AM, Hendrik Leppkes <h.leppkes at gmail.com>
> wrote:
>
>> VP9SharedContext needs to be the first member so its properties can be
>> safely accessed from hardware accelerators, without the need to share
>> the full VP9Context.
>> ---
>>  libavcodec/vp9dec.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/vp9dec.h b/libavcodec/vp9dec.h
>> index 96c0e43cd2..66573edc79 100644
>> --- a/libavcodec/vp9dec.h
>> +++ b/libavcodec/vp9dec.h
>> @@ -89,8 +89,8 @@ typedef struct VP9Block {
>>  typedef struct VP9TileData VP9TileData;
>>
>>  typedef struct VP9Context {
>> -    VP9TileData *td;
>>      VP9SharedContext s;
>> +    VP9TileData *td;
>>
>>      VP9DSPContext dsp;
>>      VideoDSPContext vdsp;
>> --
>> 2.13.2.windows.1
>
>
> Sorry for not catching that during review.
>
> Is there some way we can make hardware decoding testable in some
> fate-configuration so we can automatically catch when this sort of stuff
> breaks?
>

There has been thought about that before, by implementing a "stub"
library of the hw accelerator that just dumps the parameters submitted
for comparison in FATE, but something like that would still be a big
job.

- Hendrik