[FFmpeg-devel] [PATCH] tests/checkasm/checkasm: Provide verbose failure information on float_near_abs_eps() failures

[Michael Niedermayer]

On Fri, Apr 13, 2018 at 12:19:38AM -0300, James Almer wrote:
> On 4/12/2018 9:34 PM, Michael Niedermayer wrote:
> > This will make understanding failures and adjusting EPS easier
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  tests/checkasm/checkasm.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
> > index 20ce56932f..8a3e24f100 100644
> > --- a/tests/checkasm/checkasm.c
> > +++ b/tests/checkasm/checkasm.c
> > @@ -294,8 +294,12 @@ int float_near_ulp_array(const float *a, const float *b, unsigned max_ulp,
> >  int float_near_abs_eps(float a, float b, float eps)
> >  {
> >      float abs_diff = fabsf(a - b);
> > +    if (abs_diff < eps)
> > +        return 1;
> >  
> > -    return abs_diff < eps;
> > +    fprintf(stderr, "test failed comparing %f with %f (abs diff=%f with EPS=%f)\n", a, b, abs_diff, eps);
> 
> Maybe %g instead? I may be better to print small values, but I'm not
> sure. LGTM in any case.

%g is a good idea, ill change it to that


> 
> A few tests also output a custom log message like this one, so it may be
> a good idea to remove them now that it's done in general.

agree, not sure which messages exactly you mean though

will apply so we can easily gather more information about some failures

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180414/3f4e0c99/attachment.sig>