[FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

[wm4]

On Mon, 16 Apr 2018 09:20:09 +0200
Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Mon, Apr 16, 2018 at 12:23 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > 2018-04-15 9:41 GMT+02:00, Paul B Mahol <onemda at gmail.com>:  
> >> On 4/14/18, Rostislav Pehlivanov <atomnuker at gmail.com> wrote:  
> >>> On 14 April 2018 at 20:46, Paul B Mahol <onemda at gmail.com> wrote:
> >>>  
> >>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >>>> ---
> >>>>  libavcodec/dxv.c | 815 ++++++++++++++++++++++++++++++
> >>>> ++++++++++++++++++++++---
> >>>>  1 file changed, 780 insertions(+), 35 deletions(-)
> >>>>  
> >>>
> >>> LGTM  
> >>
> >> Applied. Thanks.  
> >
> > Thank you for working on formats like this one, I consider this
> > highly important!
> >
> > Sorry for not testing your patch earlier...
> >
> > The committed change is not helpful afaict, if you cannot fix
> > the colourspace issue (which I perfectly understand), please
> > commit your original hack (with a note), this variant cannot
> > help users.
> >  
> 
> This is not the first decoder to output YCoCg, I have H.264 files with
> that as well. Just because swscale cannot convert that doesn't mean we
> should be doing anything but non-native output from a decoder. My
> playback chain can support that just fine.
> Feel free to contribute YCoCg conversion to swscale to resolve this
> for "the users".

+1