[FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

[wm4]

On Sat, 28 Apr 2018 11:58:27 -0300
James Almer <jamrial at gmail.com> wrote:

> On 4/28/2018 8:51 AM, wm4 wrote:
> > On Sat, 28 Apr 2018 11:08:01 +0800
> > Steven Liu <lq at chinaffmpeg.org> wrote:
> >   
> >>> On 28 Apr 2018, at 03:37, wm4 <nfxjfg at googlemail.com> wrote:
> >>>  
> >   
> >>> +
> >>> +        if (strncmp(pd->name, "xyz", 3) == 0)
> >>> +            continue;    
> >>
> >> liuqideMacBook-Pro:xxx liuqi$ ../tools/patcheck ~/Downloads/FFmpeg-devel-avformat-add-vapoursynth-wrapper.patch
> >> patCHeck 1e10.0
> >> This tool is intended to help a human check/review patches. It is very far from
> >> being free of false positives and negatives, and its output are just hints of what
> >> may or may not be bad. When you use it and it misses something or detects
> >> something wrong, fix it and send a patch to the ffmpeg-devel mailing list.
> >> License: GPL, Author: Michael Niedermayer
> >> egrep: empty (sub)expression
> >>
> >> These functions may need av_cold, please review the whole patch for similar functions needing av_cold
> >> /Users/liuqi/Downloads/FFmpeg-devel-avformat-add-vapoursynth-wrapper.patch:147:+static int is_native_endian(enum AVPixelFormat pixfmt)  
> > 
> > av_cold seems dumb but I guess I can cargo-cult that.  
> 
> Unless av_cold is needed/expected for AVInputFormat->read_header like
> it's done for AVCodec->init, none of these functions need it at all.
> Especially since they will be inlined by the compiler anyway.

Only a small number of functions/formats in libavformat use av_cold.
But it doesn't harm either.

> At most, make the small ones like is_native_endian explicitly inline.

Doesn't seem needed either.