[FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

[Baozeng]

I do not agree with you. We cannot trust any user input.

2018-06-27 1:29 GMT+08:00 Michael Niedermayer <michael at niedermayer.cc>:

> On Tue, Jun 26, 2018 at 07:02:38PM +0800, Baozeng Ding wrote:
> > Signed-off-by: Baozeng Ding <sploving1 at gmail.com>
> > ---
> >  libavcodec/parser.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
>
> This looks wrong. The input must have AV_INPUT_BUFFER_PADDING_SIZE
> allocated at the end.
>
> Is the buffer you pass into the parser large enough ?
> this and the source code ive seen looked like it is too small
>
> thanks
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I know you won't believe me, but the highest form of Human Excellence is
> to question oneself and others. -- Socrates
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>


-- 
     Best Regards,
     Baozeng Ding